search

sweetrdf / rdfInterface

MIT License
6 stars 2 forks source link

feat: allow psr/http-message 2.0 #19

Closed dunglas closed 1 year ago

dunglas commented 1 year ago

No other change is necessary as the types are only used in docblocks.

k00ni commented 1 year ago

@dunglas Thanks for the pull request.

Diff between 1.1 and 2.0 looks fine, I was a bit worried about PHPStan at first. @zozlak what do you think?

dunglas commented 1 year ago

PHPStan will not complain. The only difference between v1 and v2 is the addition of type hints.

zozlak commented 1 year ago

Btw, does it mean someone else than me and k00ni uses the rdfInterface?

@dunglas, if you don't mind, I would be interested in having a quick chat with you regarding your experience and expectations.

dunglas commented 1 year ago

Thanks for the merge. Actually this package comes as a dependency of https://github.com/sweetrdf/easyrdf that we use in https://github.com/api-platform/schema-generator

Happy to chat about this.

zozlak commented 1 year ago

Ah, ok, so it's just a consequence of reusing the n-triples serializer from the rdfHelpers in the EasyRdf... Then I have no further questions.