search

sweetrdf / rdfInterface

MIT License
6 stars 2 forks source link

Opinionated refinements #5

Closed k00ni closed 3 years ago

k00ni commented 3 years ago

This PR contains some (opinionated) refinements/changes.

Summary

What do you think? Feel free to disagree.

zozlak commented 3 years ago

I removed PHPdoc entries like @return void, because its duplicated content (if function already defines it)

This is automatically generated by my IDE and will be back there every next time a function signature will change (which is maybe not so frequent by whatever). It also doesn't make any harm. So please let it go.

zozlak commented 3 years ago

I'm afraid you have just started a "spaghetti pull request" meaning you are mixing various changes in one pull request. Please avoid it. Changes in README should be considered separate from changes in coding style.

zozlak commented 3 years ago

And when it comes to code formatting - we might discuss it (although I consider it very low priority until it consistently follows any convention) but at the end of a day it's anyway a matter of taste.

Having a common taste (or at least compromise on a common taste) while developing software is important but beginning with saying "I would change it according to my taste" is not the best way of starting contributing to someones code.

k00ni commented 3 years ago

Having a common taste (or at least compromise on a common taste) while developing software is important but beginning with saying "I would change it according to my taste" is not the best way of starting contributing to someones code.

Sorry if I pissed you off, that was not my intention.

If I remember correctly you said that your main focus is not RDF + PHP anymore. Because of that I thought it is a good idea to give you a hand and provide some code suggestions. I also wanted to see, where your preferences lay so I can focus accordingly. But you are right, this PR got a little bit messy.

I will close this and make a new PR with only README.md changes.