search

swelham / ueberauth_microsoft

Microsoft Strategy for Überauth
MIT License
37 stars 35 forks source link

Implement logout #34

Open benkeil opened 3 years ago

benkeil commented 3 years ago

As far as I see, there is no logout implemented. Or did I missed something?

https://docs.microsoft.com/en-us/azure/active-directory/develop/scenario-web-app-sign-user-sign-in?tabs=aspnetcore#sign-out

swelham commented 3 years ago

Hi, thanks for raising this.

My understanding is ueberauth only focuses on authenticating requests and doesn't look to implement anything in addition to that. This doesn't necessarily mean this library couldn't support additional authentication features, though to break consistency with other ueberauth adapters I feel it would need to be clear why it is necessary.

I have had a quick look at some of the official ueberauth adapters (google, facebook, github) and those don't appear to support logout. Are you aware of any other adapters that support this feature?

benkeil commented 3 years ago

I‘m not deep enough in the topic to be honest.

I also don’t know what a User really wants. min the other hand, I expect the effort is not very high and it is not bad to have this feature?

swelham commented 3 years ago

Thanks for the feedback.

I think it would be great to look into this feature and I'm definitely open to a PR if anyone reading this is interested.