Inline git arguments

[Absolucy]

Changes

• [x] Add the ability to have inline git arguments in hook commands

Related Issues

• Closes https://github.com/swellaby/rusty-hook/issues/113

[codecov[bot]]

Codecov Report

Merging #122 into master will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #122   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          137       139    +2     
=========================================
+ Hits           137       139    +2     

Impacted Files	Coverage Δ
src/rusty_hook.rs	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 755cd44...18c8294. Read the comment docs.

[calebcartwright]

Could you update the tests to reflect the param change on run to fix the CI checks?

[Absolucy]

Done

[calebcartwright]

Done

Great! Any thoughts on my last comment https://github.com/swellaby/rusty-hook/pull/122#discussion_r496281140?

[Absolucy]

I removed the warning.

[calebcartwright]

Thanks @aspenluxxxy! The last outstanding item is the proposed variable/token sequence for substitution.

It's currently %@, but I still think we need to change this to something else. I really just want to avoid a scenario where rusty-hook is doing a replacement that's unintended and undesired by the user. I had a quick offline chat with another maintainer to see if we could think of any real scenarios where a user could potentially have %@ within a hook and not want it replaced with the git args (lemme know if I forgot anything or summarized inaccurately @beverts312).

We did come up with a few potential scenarios, and although they're fairly edge case-y and not terribly likely, the fact that we were able to come up with them pretty quickly makes me think there could indeed be some "real" use cases.

• Windows environment variables allow for leading @, and env vars are referenced by wrapping the var name in % (for example set @foo=bar and then echo %@foo%
• Could potentially occur for some string manipulation, contrived example foo=$(git config user.email) bash -c 'echo "${foo%@*}"'
• The %@ could potentially appear in a regex

As such I'd like to see the replacement string changed from %@ to something else. I'm open to anything really, but think that something longer will be better and less likely to collide with any real uses cases. For example %@rusty, %@rusty_hook, %@rhga, etc.

[Absolucy]

The %@ was originally from Objective-C, as it was simple, short, and unlikely to collide.

How about %rh!?

[calebcartwright]

I like that better, thanks :+1:

[Absolucy]

I keep pushing to the wrong branch, agh