search

swellaby / rusty-hook

git hook manager, geared toward Rust projects
MIT License
205 stars 11 forks source link

Update the Linux pipelines to use latest ubuntu vm image #167

Closed Scandiravian closed 2 years ago

Scandiravian commented 2 years ago

Changes

As discussed in #166 this updates the vm images to the latest version of ubuntu. I was unsure whether it was preferable to go with an explicit version (ubuntu-20.04), so please let me know if that would be preferred.

I couldn't find any formatting or linting recommendations for the files. By default my editor uses prettier, so I also formatted the non-linux pipelines to keep the style consistent. Let me know if I should undo the formatting or use a different tool :slightly_smiling_face:

codecov[bot] commented 2 years ago

Codecov Report

Merging #167 (3d8f2db) into master (d4795ef) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #167   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          142       142           
=========================================
  Hits           142       142

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d4795ef...3d8f2db. Read the comment docs.

calebcartwright commented 2 years ago

I couldn't find any formatting or linting recommendations for the files. By default my editor uses prettier, so I also formatted the non-linux pipelines to keep the style consistent. Let me know if I should undo the formatting or use a different tool

Thanks for adding the note. Obviously with rustfmt we're exclusively focused on .rs files, so in my experience it's been pretty common for non rust files in rust repos to not have formatting applied. I don't have any strong opinions one way or another, especially since we'll hopefully be removing those yaml files soon, but definitely something worth keeping in mind down the road.

I use prettier fairly extensively in JS/TS projects, but I wouldn't want to introduce non-Rust tooling as an entry/contribution gate to this project, so maybe it'd be helpful to add a prettier ignore or config file to the repo, just to avoid any future churn from editor/IDE plugins?