search

swellaby / rusty-hook

git hook manager, geared toward Rust projects
MIT License
207 stars 11 forks source link

ci: include rustfmt and clippy PR checks #71

Closed calebcartwright closed 5 years ago

calebcartwright commented 5 years ago

Changes

Related Issues

codecov[bot] commented 5 years ago

Codecov Report

Merging #71 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #71   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      4           
  Lines         169    169           
=====================================
  Hits          169    169
Impacted Files Coverage Δ
src/hooks.rs 100% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bd02d82...5be09ed. Read the comment docs.

calebcartwright commented 5 years ago

The coverage thing is really weird. I had the explicit return statements in that file even though it's unnecessary/not the idiomatic way, because I'd seen this before where kcov seems to think the closing } of the function is uncovered... somehow

🤷‍♂

I've reverted back to the explicit returns with a clippy disable