search

swellaby / slashhandler

Framework for building slack slashhandlers
MIT License
1 stars 0 forks source link

chore(deps): update dependency fixpack to v4 #128

Open renovate[bot] opened 3 years ago

renovate[bot] commented 3 years ago

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
fixpack ^3.0.6 -> ^4.0.0 age adoption passing confidence

Release Notes

henrikjoreteg/fixpack ### [`v4.0.0`](https://togithub.com/henrikjoreteg/fixpack/compare/v3.0.6...v4.0.0) [Compare Source](https://togithub.com/henrikjoreteg/fixpack/compare/v3.0.6...v4.0.0)

Configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

This PR has been generated by WhiteSource Renovate. View repository job log here.

calebcartwright commented 3 years ago

@beverts312 - i don't imagine getting around to this in the near future, but any thoughts/concerns with the update? The one thing that jumps out to me is the change of the default behavior to maintain existing indentation levels, and line feeds, and instead requiring configuration to change those.

i've become rather partial to two space indents for json files myself, but that being said, i've also become rather partial to code formatters like prettier too. if we were to introduce something like prettier, both for the source TS files, json, and the others, then we could leave the fixpack defaults as-is and let it do the reordering and such, and then just rely on prettier for indentation, line endings, etc.