is multiworkspace supported?

swellaby / vscode-rust-test-adapter

Rust Test Explorer extension for VS Code

MIT License

56 stars 10 forks source link

is multiworkspace supported? #193

Open sweetim opened 2 years ago

sweetim commented 2 years ago

i have workspace that contains a mixture of rust and non rust projects, in the test explorer it displays a list of drop down, but each drop down contains no test items

calebcartwright commented 2 years ago

Are you referring to multi root workspaces? If so, I believe the answer is still no, although if you have a minimal repro that could be used to reproduce that would be helpful as well

sweetim commented 2 years ago

yes, multi root workspaces

there are 2 problems i) when new rust workspace is added, it will break the test explorer (as reported above) ii) if non rust is included in workspace, it displays duplicated test cases from other rusts workspace

Reproduce for (i)

create 2 rust folder (with tests or without tests)
add both of the folder into workspace, and the rust explorer will break

Reproduce for (ii)

add any non rust folder into the workspace, the test explorer will duplicate the same test cases from other rust folder

calebcartwright commented 2 years ago

add both of the folder into workspace, and the rust explorer will break

Could you define "break" more concretely? As I alluded to in my prior comment we don't expect multiroot workspaces to be supported, but break can mean different things (e.g. simply not detecting/loading tests vs. logging errors vs. crashing vs. etc.)

sweetim commented 2 years ago

break in that statement means all the workspace are named as rust in the test explorer, and when click on each drop down it displays nothing

will wait for the release of multi root workspace support, maybe it is good to add a description in the README.md that explicitly inform user that the multi root workspace is not supported yet?