swellstores / horizon

Headless NextJS storefront starter powered by Swell
https://swell-horizon-demo.vercel.app/
MIT License
58 stars 52 forks source link

fix: US dollar is hardcoded in the Horizon theme #54

Closed DmitrijOp closed 11 months ago

DmitrijOp commented 11 months ago

Issue link: US dollar is hardcoded in the Horizon theme

This happened because we didn't change the store's currency to the one that was set in the admin panel.

https://github.com/swellstores/horizon/assets/145032708/3453dc3d-99fa-4b21-a8d3-1eb060ea0e12

vercel[bot] commented 11 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
horizon ❌ Failed (Inspect) Sep 19, 2023 4:56pm
swell-horizon-github ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 19, 2023 4:56pm
logeshswell commented 11 months ago

@DmitrijOp Can you try yarn run build to debug the build failure for swell-horizon-github?

Screenshot 2023-09-19 at 3 03 27 PM
DmitrijOp commented 11 months ago

@DmitrijOp Can you try yarn run build to debug the build failure for swell-horizon-github?

Screenshot 2023-09-19 at 3 03 27 PM

Strange, it works fine on my local. I will try to fix it

image

Done, @logeshswell

logeshswell commented 11 months ago

LGTM

DmitrijOp commented 11 months ago

LGTM

@logeshswell

Maybe you know how these changes can be verified by the QA side?

Susanna said that changes used to be posted here https://horizon-demo.swell.store/ and could be checked here.

logeshswell commented 11 months ago

Maybe you know how these changes can be verified by the QA side?

Susanna can test the fix using the below link which contains your latest changes. https://swell-horizon-github-git-fix-us-dollar-hardcoded-swell.vercel.app/

DmitrijOp commented 11 months ago

Maybe you know how these changes can be verified by the QA side?

Susanna can test the fix using the below link which contains your latest changes. https://swell-horizon-github-git-fix-us-dollar-hardcoded-swell.vercel.app/

Thanks Do we have admin for this store? For testing we need to remove currencies

logeshswell commented 11 months ago

Do we have admin for this store? For testing we need to remove currencies

SWELL_STORE_ADMIN_URL: https://horizon-demo.swell.store/admin SWELL_STOREFRONT_ID: 5qWj7DQt

Changes made here might affect the live demo storefront. So, please revert the store settings after your testing.