search

swellstores / swell-js

JS library for building storefronts and checkouts with Swell ecommerce.
https://swell.is
MIT License
138 stars 29 forks source link

types: CVC should not be a number #105

Closed jezzzm closed 1 month ago

jezzzm commented 1 year ago

needs to allow strings that begin with zero.

e.g. passing to card.createToken:

currently, by coercing the string "089" to a number in order to appease Swell types, 89 is passed to the validation function and therefore fails as it is only 2 digits.

ericingram commented 1 year ago

Good point cc @greph

greph commented 1 year ago

Ah that's a great call out. Taking a look.

On Tue, May 2, 2023 at 10:47 AM Eric @.***> wrote:

Good point cc @greph https://github.com/greph

— Reply to this email directly, view it on GitHub https://github.com/swellstores/swell-js/issues/105#issuecomment-1531891746, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAN5NFD3PF5MSNLLWEXR3K3XEFCCBANCNFSM6AAAAAAXS2MMSA . You are receiving this because you were mentioned.Message ID: @.***>

-- Greg Hoskin (650) 665-0924 @.***

awwit commented 4 months ago

@jezzzm this should be fixed in v4.1.1.