search

swennemans / react-text-highlighter

Simple HOC for highlighting text.
8 stars 0 forks source link

HMR in prod env #1

Open tom-s opened 8 years ago

tom-s commented 8 years ago

Hi,

Great work ! I have an issue when building my app in a non dev environment. Your js files in the lib folder includes HMR stuff

var _reactTransformHmr2 = require('react-transform-hmr'); var _reactTransformHmr3 = _interopRequireDefault(_reactTransformHmr2);

which should not be there. My prod env doesn't have react-transform-hmr so babel throws error when trying to build my app. I suspect you build your lib folder in a dev env rather that non dev ?

Thanks for your help

swennemans commented 8 years ago

Sorry about this extremely late reply. I've missed the notification. Is it still a problem for you or did you move along?

tom-s commented 8 years ago

No worries. Well the issue is still there ^^

Erid commented 7 years ago

We're having the same issue, it would be solved by building the application without NODE_ENV being development and re-publishing the project.