RandomUsername1315 commented 3 months ago

Pull Request Overview

This PR introduces a new UI screen for users. When a user clicks on a specific recipe from the recipe recommendation screen, they will be taken to a new screen that displays additional information such as specific ingredients and calorie count.

Main Changes

Modify Ingredient.kt: Updated to store a URI which will be used to display the ingredient's image.
Create IngredientInfoCard.kt class: Displays an image of the ingredient along with its name and amount.
Create NutriInfoCard.kt class: Summarizes the nutritional values of a meal, highlighting key values such as calories and fats.
Create TitleAndToggleCard.kt class: Card containing two buttons, with one being activatable.
Create RecipeRecFlow.kt class: Represents the flow between the recipe recommendation screens.
Create RecipeRecommendationMoreDetailScreen.kt class: The screen that displays more detailed information about a specific recipe.

Video of the New Implementation

View the implementation video

Future PR

Modify the ViewModel and the Spoonacular API to handle the new functionalities.
Adjust the recipe instruction card to better align with the API's style.

Note for Reviewers

It may appear as a large number of code lines, but this is due to moving some tests from the unit test folder to the Android test folder. This caused Git to recognize them as new files. This move was necessary because Uri.EMPTY is not implemented in the unit test folder, which caused numerous issues.
All API calls for this implementation have been replaced by mocks because we have reached the monthly limit for the API.

medwardson commented 3 months ago

I don't have the time to review yet (hopefully tomorrow morning), but, from the demo my suggestion is to add some padding around the recipe instructions text, and if possible, find a better way for formatting the text to avoid missing spaces

RandomUsername1315 commented 3 months ago

@medwardson this will be taken care by the branche : feature/ui/recipe-rec-more-detail. This is because it depends on which api call we decide to use. Normally it should look like the figma.

sonarcloud[bot] commented 3 months ago

Quality Gate passed

Issues
7 New issues
0 Accepted issues

Measures
0 Security Hotspots
63.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

swent-group10 / polyfit