fix alvin links - Githubissues

BobBorges commented 2 months ago

fix alvin link generation in person catalog

ninpnin commented 2 months ago

Can you send an example link?

salgo60 commented 1 month ago

Can you send an example link?

@ninpnin you have examples on WD Property:P6821#P1855

There are at least 4 index types

Place ex. alvin-place:684
Organisation ex. alvin-organisation:1049
People ex. alvin-person:695
Record ex. alvin-record:179727

alvin-portal.org

BobBorges commented 1 month ago

@ninpnin Sorry, I didn't see this.

e.g. This guy

i-YVqWZSiikwY2UYC3gt2RvM.json:      "identifier": "alvin-person:49059",
i-YVqWZSiikwY2UYC3gt2RvM.json:      "link": "https://www.alvin-portal.org/alvin/view.jsf?pid=alvin-person:49059"

The link is broken at https://swerik-project.github.io/person-catalog/i-YVqWZSiikwY2UYC3gt2RvM/, but I think it's fixed in the open PR on the website repo: see here https://github.com/swerik-project/swerik-project.github.io/blob/catalog-v1.1.0/_data/_person-catalog/i-YVqWZSiikwY2UYC3gt2RvM.json#L82

This PR has code to generate the links correctly.

ninpnin commented 1 month ago

LGTM

swerik-project / pyriksdagen

fix alvin links #10