search

swerik-project / pyriksdagen

MIT License
0 stars 0 forks source link

filter db by date #3

Closed BobBorges closed 6 months ago

BobBorges commented 6 months ago

Filter the db by date when detecting ministers. This is handy when we have the role and date but not a name.

BobBorges commented 6 months ago

Is sth wrong (?) with the notebook? @ninpnin

ninpnin commented 6 months ago

politicians -> persons

ninpnin commented 6 months ago

LGTM. In the future, we want to use logging / trainerlog , so that it's easy to turn prints on and off.

BobBorges commented 6 months ago

Yes, I should not have committed the print statement... sorry 'bout that.

ninpnin commented 6 months ago

Should we make the notebook update the date / version every time we merge to main?

BobBorges commented 6 months ago

That would be most professional.