search

swerik-project / riksdagen-persons

A repository for metadata on politicians who participate in the Riksdag.
0 stars 1 forks source link

Rename the repo #2

Closed MansMeg closed 5 months ago

MansMeg commented 6 months ago

I think Jan had some good ideas on names. I think it was officials or elected-officials.

BobBorges commented 6 months ago

riksdagen-officials? This seems reasonable. I needed to create the repository to get on with the work, but now we have time to discuss it and decide without rush.

MansMeg commented 6 months ago

Yes. There is no rush.

public-officials ?

fredrik1984 commented 6 months ago

Jan's suggestion was "political officials". I don't think this is the best name though. We want a name that captures elected MPs, ministers who were not MPs, the monarch, and potential other speaking guests. Regarding the latter, for example, the Swedish author Kerstin Ekman (not an MP) held a speech in the chamber during the ceremonial opening of the Riksdag in 1988 (https://data.riksdagen.se/fil/B32B0893-0238-4E37-957A-8B73A0EC43B3).

Here are three other suggestions:

riksdagen-individuals

riksdagen-persons

riksdagen-poeple

However, none of these three seem intuitive from a user perspective. Users are likely to think in terms of "MPs" or "politicians". Maybe Bob's suggestion of "riksdagen-officials" is closer to what we want.

MansMeg commented 6 months ago

Riksdagen persons seem like the best to me.

MansMeg commented 5 months ago

I think with riksdag-persons if no one complains about this. It would be good to change this before we release version 1.0 of the repository.

BobBorges commented 5 months ago

riksdagen-persons ok? riksdagen as opposed to riksdag to match the other repos.

MansMeg commented 5 months ago

Yes. Sorry, we should match the other repos.

MansMeg commented 5 months ago

@fredrik1984 and @ninpnin , you ok with this?

fredrik1984 commented 5 months ago

Yes, "riksdagen-persons" works, it will capture most of it.

ninpnin commented 5 months ago

Fine by me. Let's check where we refer to the repo first though

BobBorges commented 5 months ago

In my arrangement, the only important places are in the gh workflows for the release repo and records repo.

ninpnin commented 5 months ago

I think there is a hard coded URL in the download_corpus() function too

ninpnin commented 5 months ago

https://github.com/swerik-project/pyriksdagen/blob/main/pyriksdagen/utils.py#L235 hmm, looks like it would be passed as an argument instead! So all good on that front

ninpnin commented 5 months ago

The notebook example does have the name in it https://github.com/swerik-project/pyriksdagen/blob/main/examples/corpus-walkthrough.ipynb