LIB: fix invalid access to past last element

[hfiguiere]

• Accessing a vector element past the last (idx >= size) is UB and will trigger an assertion when built with assertions

The plugin was aborting on load when built as a flatpak. (default CXX flags have C++ assertions enabled)

[swesterfeld]

Yes, I agree this is UB and needs to be fixed. From a quick look at the source code, this is not the only place where &foo[foo.size()] is used. I'll try to find the other spots as well and fix it everywhere. Also I think that &foo[0] is also a problem because it will cause out-of-bounds errors if the vector is empty, so this probably also needs fixing by using the data() function of std::vector instead, which can also be used for empty vectors.

Interestingly the address sanitizer and UB sanitizer don't really find this bug, but I can reproduce your "crash" by compiling with -D_GLIBCXX_DEBUG -D_GLIBCXX_DEBUG_PEDANTIC.

[hfiguiere]

Also I think that &foo[0] is also a problem because it will cause out-of-bounds errors if the vector is empty

That one too.

Maybe MMapIn::open_mem could take iterators that return the proper type.

[swesterfeld]

I ended up with adding a method MMapIn::open_vector which does the right thing. The code is merged now (https://github.com/swesterfeld/spectmorph/commit/d9454670670c17ec7a9b3e348e07fb3a08c2c443), I hope I found every spot in the code that needed fixing. At least a bit of testing worked for me.

[hfiguiere]

BTW -Wp,-D_GLIBCXX_ASSERTIONS in CXXFLAGS is enough to trigger it. And UB sanitizer doesn't know about the C++ library. This is the semantincs of the [] operator.

Thanks !