search

swethadevireddy / ToDoApp

Android ToDo App
0 stars 1 forks source link

Todo App #1

Open swethadevireddy opened 7 years ago

swethadevireddy commented 7 years ago

My app is complete, please review. @codepathreview @codepath.

I have submitted the assignment with optional features too.

When working on the additional features noticed

  1. getView (TodoListAdapter) is invoked twice for add and edit Todo (logs in this method are printing twice in logcat), I am calling itemsAdapter.notifyDataSetChanged() only once. May I know why is it ? I will also continue to read and investigate further.
  2. For highlighting the new added/edited Todo item , I have used animation for setting background color to fadeout in 2 sec.For this feature if I am using the tag from cache instead of creating new view holder , when adding new item after edit last row is being highlighted in addition to new added item.Consequent edits are working fine though.The scenario is in comments section on line @43 of TodoListAdapter.java.I tried to debug this , creating new view holder fixed this issue.I guess this is not ideal for long list . can you please let me know what is the issue with using tag from cache
codepathreview commented 7 years ago

Hello Swetha,

Looks great, this exercise is intended in part to give you an introduction to the general rhythm of this course. The course is entirely project-based with an app being assigned each week and then due the following week. Each project builds on the last to help each engineer learn the practical elements of Android development and best practices as quickly as possible. We also do a code review for each submitted project once the program begins.

Great to see you were able to complete a large number of extensions to your app already. Your project looks great. As you can probably tell, the extension tasks available on each project are the valuable learnings since they dive deeper into common real-world Android use cases.

Be sure to take a look through our organizing your source files guide for tips on organizing your code as well.

Now that you've completed the pre-work, we'll be following up with you again shortly to outline the next steps in the admissions process.