sweverett / Balrog-GalSim

Modules for GalSim that will be useful for DES images in conjunction with Balrog.
MIT License
5 stars 5 forks source link

Allow all native GalSim types in Balrog code #47

Open sweverett opened 6 years ago

sweverett commented 6 years ago

When the code was first written, we were extremely conservative about what sorts of input and config types were allowed to be passed in the bal_config to ensure that we were doing things correctly.

However, this is too conservative: It leads to some unexpected and unnecessary compatibility issues when doing simple tests using typical galsim types.

We should change all of the allowed_types into safe_types or supported_types and only warn the user if using one of the unsupported types. This shifts some of the responsibility to the user to do reasonable things, but this is an ok compromise for flexibility.