sweverett / Balrog-GalSim

Modules for GalSim that will be useful for DES images in conjunction with Balrog.
MIT License
5 stars 5 forks source link

GSObject creation in `ngmix2gs` should pass shape parameters directly to `GMixCM` #53

Closed sweverett closed 5 years ago

sweverett commented 5 years ago

The current conversion of ngmix profile to a GSObject has a subtle bug - the shape parameters are used to shear the circular object after profile creation (like a GSObject normally would) instead of being used in the initial creation of a GMixCM object (whose shape parameter cm_T is not circular!). We simply need to pass (g1,g2) to cm_params in the creation of a BalGMixCM object to fix this.

This resolves ~90% of the image residual discrepancy that Katie has seen in her tests.