search

sweverett / CluStR

Calculates various scaling relations from cluster catalogs.
5 stars 4 forks source link

Python 3 Compatability #12

Open sweverett opened 7 years ago

sweverett commented 7 years ago

We should probably convert everything to be Python 3 compatible, just to be forward looking :)

sweverett commented 4 years ago

Re-emphasizing this now that we live in a post Python-2 world! We should write the clustr rewrite completely in Python 3 now that Python 2 is dead, RIP.

jjobel commented 4 years ago

Now that we've closed issue #39, can I go ahead and tackle this issue. Last week I was running clustr on python 3 just fine but now that I created a new clustr environment with python 2 I'm wondering if I should jump back on to python 3 (along with updated libraries)? It seems like there's a small amount of changes that need to done on clustr.py.

jjobel commented 4 years ago

Just ran the code in python 3 and it works fine.

sweverett commented 4 years ago

If linmix is behaving with python3, then no reason to stay with 2. My main concern was with rpy2, but we no longer need that package since we are sticking with the Kelly method.

jjobel commented 4 years ago

Okay awesome!