swh / ladspa

The SWH Plugins package for the LADSPA plugin system
http://plugin.org.uk/
GNU General Public License v2.0
229 stars 52 forks source link

Allow older versions of gettext #51

Closed tresf closed 7 years ago

tresf commented 7 years ago

Gettext 0.18.3 works just fine and lowers the requirements for older build systems. @hartwork FYI, partially reverts 01c7745.
Tested on Ubuntu 14.04.

hartwork commented 7 years ago

Please check #25 for why I bumped to gettext 0.19.x back then. 0.18.3 may still do, but I rely on you for testing.

tresf commented 7 years ago

@hartwork:

ubuntu@ubuntu1404:~/ladspa$ cat /etc/lsb-release 
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=14.04
DISTRIB_CODENAME=trusty
DISTRIB_DESCRIPTION="Ubuntu 14.04.5 LTS"
ubuntu@ubuntu1404:~/ladspa$ gettext --version
+gettext (GNU gettext-runtime) 0.18.3
Copyright (C) 1995-1997, 2000-2007 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
Written by Ulrich Drepper.

Mine (red, pretend they're plusses) versus yours (green)

+ Copying file ABOUT-NLS
  Copying file config.rpath
- Creating directory m4
  Copying file m4/codeset.m4
+ Copying file m4/extern-inline.m4
  Copying file m4/fcntl-o.m4
  Copying file m4/gettext.m4
  Copying file m4/glibc2.m4
  Copying file m4/glibc21.m4
  Copying file m4/iconv.m4
  Copying file m4/intdiv0.m4
  Copying file m4/intl.m4
  Copying file m4/intldir.m4
  Copying file m4/intlmacosx.m4
  Copying file m4/intmax.m4
  Copying file m4/inttypes-pri.m4
  Copying file m4/inttypes_h.m4
  Copying file m4/lcmessage.m4
  Copying file m4/lib-ld.m4
  Copying file m4/lib-link.m4
  Copying file m4/lib-prefix.m4
  Copying file m4/lock.m4
  Copying file m4/longlong.m4
  Copying file m4/nls.m4
  Copying file m4/po.m4
  Copying file m4/printf-posix.m4
  Copying file m4/progtest.m4
  Copying file m4/size_max.m4
  Copying file m4/stdint_h.m4
  Copying file m4/threadlib.m4
  Copying file m4/uintmax_t.m4
  Copying file m4/visibility.m4
  Copying file m4/wchar_t.m4
  Copying file m4/wint_t.m4
  Copying file m4/xsize.m4
  Copying file po/Makefile.in.in
  Copying file po/Makevars.template
  Copying file po/Rules-quot
  Copying file po/boldquot.sed
  Copying file po/en@boldquot.header
  Copying file po/en@quot.header
  Copying file po/insert-header.sin
  Copying file po/quot.sed
- Copying file po/remove-potcdate.sin

Edit: The rest of the files seem to be there so if this reversion to older gettext causes a bug, I would need help identifying it.

I don't know this build system (at all) so I hope this provides enough information for a decision. If not, let me know and I can dig some more information.

hartwork commented 7 years ago

For extern-inline.m4: http://git.savannah.gnu.org/cgit/gettext.git/tree/gettext-runtime/m4/extern-inline.m4