swh / ladspa

The SWH Plugins package for the LADSPA plugin system
http://plugin.org.uk/
GNU General Public License v2.0
230 stars 52 forks source link

Fix Impulse convolver #68

Closed nobry closed 4 years ago

nobry commented 4 years ago

This fixes having this effect with different instruments as the last instrument only worked, with only one audio channel. The problem came from having fft plans as global, since each plan contain data mapping to the specified memory address given in parameter, meaning each new instance would overwrite the previous configuration. This follows the impulse generation process of setting the global variable then using them right away.

I originally made changes in the generated .c file with these edits, but I don't know how to force file re-generation from XML. I think it would work as such, or with minor fixes.