search

swh / lv2

SWH Plugins in LV2 format
http://plugin.org.uk/
GNU General Public License v3.0
93 stars 20 forks source link

Allocate memory during instantiation, fixing segfaults in a few plugins #18

Closed cbix closed 2 years ago

cbix commented 2 years ago

This fixes #8 and fixes #13 + segfaults when testing with lv2lint by moving memory allocation in affected plugins from activation to instantiation.

allpass, comb and delay should also not set the buffer size based on the max_delay control, which is now left as a dummy port. I guess the idea was to let users set the max buffer size as a means of manual memory optimization, but can cause issues (again, malloc during activation) and LV2 hosts usually don't let users set parameters upon instantiation.

Also would be great to eventually have another stable release tagged, we're currently packaging this for Arch Linux with this patch applied :)

Thanks!

swh commented 2 years ago

Great, thank you very much!

I will look into making a release soon.

cbix commented 2 years ago

I will look into making a release soon.

@swh that would be great!