search

swharden / FftSharp

A .NET Standard library for computing the Fast Fourier Transform (FFT) of real or complex data
https://nuget.org/packages/FftSharp
MIT License
318 stars 45 forks source link

Hamming Window in ver.1.1.3 #44

Closed unitay closed 2 years ago

unitay commented 2 years ago

Why Cosine, Hamming, Tukey and Welch windows is internal? Why Window.NormalizeInPlace is internal? How to use this in inherited class?

swharden commented 2 years ago

Hi @unitay,

Making those windows internal was not intentional. I'll make them public and issue a new release tonight.

I'm curious - what functionality are you adding by inheriting/extending these classes? These classes are pretty simple (e.g., Hamming.cs) so I'm interested in learning more about your use case.