swhitty / SwiftDraw

Swift library and command line tool to convert SVGs into SFSymbol, PNG, PDF and Swift source code.
zlib License
326 stars 41 forks source link

Only wind fill paths #31

Closed swhitty closed 8 months ago

swhitty commented 8 months ago

SFSymbols using fill-rule: evenOdd need to be converted to non zero winding rule only when filling.

When a path is stroked — expanded on Darwin platforms using with replacePathWithStrokedPath(), then no conversion is required.

codecov[bot] commented 8 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e92302a) 85.33% compared to head (bd3ea7f) 85.34%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #31 +/- ## ======================================= Coverage 85.33% 85.34% ======================================= Files 77 77 Lines 7024 7026 +2 ======================================= + Hits 5994 5996 +2 Misses 1030 1030 ``` | [Files](https://app.codecov.io/gh/swhitty/SwiftDraw/pull/31?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Whitty) | Coverage Δ | | |---|---|---| | [SwiftDraw/Renderer.SFSymbol.swift](https://app.codecov.io/gh/swhitty/SwiftDraw/pull/31?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Whitty#diff-U3dpZnREcmF3L1JlbmRlcmVyLlNGU3ltYm9sLnN3aWZ0) | `85.28% <92.30%> (+0.07%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.