search

swhitty / SwiftDraw

Swift library and command line tool to convert SVGs into SFSymbol, PNG, PDF and Swift source code.
zlib License
423 stars 51 forks source link

Correctly handle image sizes #41

Closed swhitty closed 5 months ago

swhitty commented 5 months ago

Fixes a defect where Image tags were ignoring any input sizes and positions. https://github.com/swhitty/SwiftDraw/issues/40

Positions and Sizes and now respected but are not optional and default to the size within the bitmap image if not provided within the SVG.

fix
codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 92.53731% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 84.07%. Comparing base (2823463) to head (040031e).

Files Patch % Lines
SwiftDraw/Renderer.CGText.swift 0.00% 3 Missing :warning:
SwiftDraw/LayerTree.CommandGenerator.swift 88.88% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #41 +/- ## ========================================== + Coverage 84.04% 84.07% +0.02% ========================================== Files 77 77 Lines 5391 5426 +35 ========================================== + Hits 4531 4562 +31 - Misses 860 864 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.