swift-extras / swift-extras-json

JSON encoding and decoding without the use of Foundation in pure Swift.
Apache License 2.0
348 stars 15 forks source link

Creating Bytes from JSONValue with a Pointer #2

Open fabianfett opened 4 years ago

fabianfett commented 4 years ago

This is an idea on improving the encoding speed. Doesn't seem to work though.

fabianfett commented 4 years ago

Codecov Report

Merging #2 into master will increase coverage by 1.21%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #2      +/-   ##
==========================================
+ Coverage   70.16%   71.37%   +1.21%     
==========================================
  Files          22       23       +1     
  Lines        1790     2264     +474     
==========================================
+ Hits         1256     1616     +360     
- Misses        534      648     +114     
Impacted Files Coverage Δ
Tests/JSONParsingTests/StringParserTests.swift 90.71% <0.00%> (-9.29%) :arrow_down:
Sources/PureSwiftJSONParsing/JSONValue.swift 48.96% <0.00%> (-42.38%) :arrow_down:
Tests/JSONParsingTests/BoolParserTests.swift 94.68% <0.00%> (-2.05%) :arrow_down:
Tests/JSONParsingTests/NullParserTests.swift 93.75% <0.00%> (-1.49%) :arrow_down:
...ingTests/Learning/FondationJSONSerialization.swift 72.22% <0.00%> (ø)
Sources/PureSwiftJSONParsing/JSONParser.swift 92.94% <0.00%> (+1.70%) :arrow_up:
Sources/PureSwiftJSONParsing/DocumentReader.swift 94.08% <0.00%> (+6.36%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 59d69a7...a48acbe. Read the comment docs.

fabianfett commented 4 years ago

@Joannis thanks for your guidance.