swift-extras / swift-extras-json

JSON encoding and decoding without the use of Foundation in pure Swift.
Apache License 2.0
348 stars 15 forks source link

Create CodingPerfTests executable #57

Closed pokryfka closed 4 years ago

pokryfka commented 4 years ago

also updated README and CI workflow

codecov[bot] commented 4 years ago

Codecov Report

Merging #57 into main will increase coverage by 0.06%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
+ Coverage   90.73%   90.79%   +0.06%     
==========================================
  Files          40       39       -1     
  Lines        3378     3325      -53     
==========================================
- Hits         3065     3019      -46     
+ Misses        313      306       -7     
Impacted Files Coverage Δ
...sts/LearningTests/FoundationJSONEncoderTests.swift 91.83% <0.00%> (-1.15%) :arrow_down:
...sts/LearningTests/FoundationJSONDecoderTests.swift 93.29% <0.00%> (-0.08%) :arrow_down:
...arningTests/FoundationJSONSerializationTests.swift

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fdbb3d9...715002a. Read the comment docs.

fabianfett commented 4 years ago

@pokryfka Thank you. This is great! I haven‘t known about swift run before.

pokryfka commented 4 years ago

👍

I was surprised binary was linked without defining executable product :-) (maybe that was because there is just one file and external libs are dynamically linked?)

.executable(name: "CodingPerfTests", targets: ["CodingPerfTests"]),

swift run -c release is debatable but I think its good in that it does not assume .build structure which, event though unlikely, might change, its an implementation detail after all