swift-extras / swift-extras-json

JSON encoding and decoding without the use of Foundation in pure Swift.
Apache License 2.0
348 stars 15 forks source link

Fix semantics of JSONUnkeyedDecodingContainer #62

Closed gwynne closed 4 years ago

gwynne commented 4 years ago

The following behaviors are now handled correctly:

gwynne commented 4 years ago

If anything I've done affects performance significantly please let me know so I can undo it.

codecov[bot] commented 4 years ago

Codecov Report

Merging #62 into main will increase coverage by 0.32%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #62      +/-   ##
==========================================
+ Coverage   85.24%   85.57%   +0.32%     
==========================================
  Files          13       13              
  Lines        1227     1234       +7     
==========================================
+ Hits         1046     1056      +10     
+ Misses        181      178       -3     
Impacted Files Coverage Δ
...ftJSON/Decoding/JSONUnkeyedDecodingContainer.swift 98.23% <100.00%> (+2.94%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e20673f...89b37dc. Read the comment docs.

fabianfett commented 4 years ago

@gwynne Thanks so much, from what I’ve skimmed this looks awesome. I’m on vacation right now, but I’ll have a thorough look on Sunday.

fabianfett commented 4 years ago

Thanks @gwynne and @calebkleveter!