Closed gwynne closed 4 years ago
If anything I've done affects performance significantly please let me know so I can undo it.
Merging #62 into main will increase coverage by
0.32%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #62 +/- ##
==========================================
+ Coverage 85.24% 85.57% +0.32%
==========================================
Files 13 13
Lines 1227 1234 +7
==========================================
+ Hits 1046 1056 +10
+ Misses 181 178 -3
Impacted Files | Coverage Δ | |
---|---|---|
...ftJSON/Decoding/JSONUnkeyedDecodingContainer.swift | 98.23% <100.00%> (+2.94%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update e20673f...89b37dc. Read the comment docs.
@gwynne Thanks so much, from what I’ve skimmed this looks awesome. I’m on vacation right now, but I’ll have a thorough look on Sunday.
Thanks @gwynne and @calebkleveter!
The following behaviors are now handled correctly:
self.count
orself.isAtEnd
to accidentally get out of sync with reality, they are now computed.DecodingError
thrown (may have performance implications; removing this check is not strictly against protocol if so).decodeNil()
no longer incorrectly increments the current index if the result is notnil
.