swift-nav / libswiftnav-legacy

A portable C library implementing GNSS related functions and algorithms.
GNU Lesser General Public License v3.0
100 stars 85 forks source link

Add Glonass support to signal.c/h #325

Closed pmiettinen closed 8 years ago

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.05%) to 54.0% when pulling a318478a6c9a2f62277401d576cbc5dbdbe1d161 on pmiettinen:i129-glo-signal-ch into cd0f64098fa8629ace8cb5f69f327b8de2265263 on swift-nav:master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.05%) to 54.0% when pulling 8f1c641342e8c51b0eb9479abc00a4cb9c269b68 on pmiettinen:i129-glo-signal-ch into cd0f64098fa8629ace8cb5f69f327b8de2265263 on swift-nav:master.

ljbade commented 8 years ago

LGTM. Coveralls failure is strange, only new executable code is in the test.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.05%) to 54.0% when pulling bc75d2ed33f72effb85ea2b98a943066d8c5ceff on pmiettinen:i129-glo-signal-ch into cd0f64098fa8629ace8cb5f69f327b8de2265263 on swift-nav:master.

pmiettinen commented 8 years ago

@ljbade I made addition to unit test to bring up the signal.c coverage to 100.

ljbade commented 8 years ago

Excellent, I think it's ready to merge

pmiettinen commented 8 years ago

@ljbade Who does the merging? I don't have rights.

ljbade commented 8 years ago

I can