swift-project / pilotclient

Cross-platform cross-simulator pilot client for virtual air traffic networks
https://swift-project.org
GNU General Public License v3.0
94 stars 28 forks source link

Remove custom stylesheet + add selectable stylesheet directory #138

Open jonaseberle opened 2 years ago

jonaseberle commented 2 years ago

By default my desktop environment's dark mode leads to unusable menus with the SwiftGUI standard stylesheet: image

I also found the GUI really not very appealing as it was. I think even just having the custom background images and colors is a usability problem.

One could try to improve the stylesheet, maybe it is possible to make it dark mode aware etc.etc. - or get to the root of the problem: the custom stylesheet.

I have made a test and just removed anything from the .qss stylesheet files - and this is a revelation. Suddenly the GUI looks more professional and is easier to use. I get my nice desktop environment accent color and widget style and all the work those designers and developers put into better usability of these Qt widgets for free:

image

So I propose to make this the default: Only provide styles where really needed.

Selecting a custom stylesheet could then go into the settings. IMHO it should be done by selecting a custom directory holding your overwriting .qss files so Swift updates do not overwrite your custom styles (docs and docs). Here image on the very top would be a good place for that directory selector IMHO.

If that sounds good (or bad) to you, please leave a comment. I could work on it.

oktal3700 commented 2 years ago

Please open a separate issue for the dark mode bug. That will need to be fixed in any case.

I like your proposal, but we will have to take care that it doesn't cause any unintended breakages if there is any code that depends on specific attributes of the stylesheet.

jonaseberle commented 2 years ago

tbh I would not advise to work on trying to fix the current stylesheet. If it becomes optional it will be just one among others and does not have to be maintained any more.