search

swift-project / pilotclient

Cross-platform cross-simulator pilot client for virtual air traffic networks
https://swift-project.org
GNU General Public License v3.0
94 stars 27 forks source link

Request configurable network connect/disconnect notification sound #156

Closed FlyingFoxVATSIM closed 9 months ago

FlyingFoxVATSIM commented 2 years ago

Could we add a configurable sound for when users connect/disconnect from the network server?

Also, we can probably remove the sound events "no audio transmission warning", "ATC frequency selected" and "ATC frequency deselected".

ltoenning commented 10 months ago

Could we add a configurable sound for when users connect/disconnect from the network server?

You mean when the swift user connects itself or if other users "appear" in the vicinity? The first case should already work with the login.wav and logoff.wav files, shouldn't it?

Also, we can probably remove the sound events "no audio transmission warning", "ATC frequency selected" and "ATC frequency deselected".

I agree on the "no audio transmission warning". This is not used anymore. "ATC frequency selected" and "ATC frequency deselected" is still used in the code. Aren't these notification sounds not working (anymore)?

FlyingFoxVATSIM commented 10 months ago

"ATC frequency selected" and "ATC frequency deselected" is still used in the code. Aren't these notification sounds not working >(anymore)?

Yes, they still work, I just tested them. However, does anyone use them?

Re the connect/disconnect sounds: we actually do have something already, login.wav and logoff.wav. My idea was to have an option to configure them, but I guess users should just replace those files with their custom wav-files, as we do with the other sound files.

ltoenning commented 10 months ago

However, does anyone use them?

Maybe not very common. I am fine with removing these two options as well.

Re the connect/disconnect sounds: we actually do have something already, login.wav and logoff.wav. My idea was to have an option to configure them, but I guess users should just replace those files with their custom wav-files, as we do with the other sound files.

I would prefer a single method for customizing notification sounds. Adding another method only complicates things.

FlyingFoxVATSIM commented 10 months ago

I do agree, but then we'd have to add them to the Audio page of swiftGUI.