search

swift-project / pilotclient

Cross-platform cross-simulator pilot client for virtual air traffic networks
https://swift-project.org
GNU General Public License v3.0
94 stars 27 forks source link

Many audio streams on audio systems that allow stream routing #163

Open jonaseberle opened 2 years ago

jonaseberle commented 2 years ago

On Linux (pusleaudio/pipewire) we see many audio streams from Swift:

image

I would believe the same is the case on Mac/CoreAudio? Since I've seen Windows users ask for in-app routing, I believe they don't see each stream? @FlyingFoxVATSIM

1) Could we name them appropriately? (E.g. "Swift PTT click") 2) Is this flexibility really needed? Couldn't we reuse some streams and get rid of the rest? "Swift COM1", "Swift COM2", "Swift sound effects" would be sufficient IMHO.

ltoenning commented 10 months ago

The majority of these streams are generated by the QSoundEffect's within the CNotificationPlayer. A distinct stream is created for each QSoundEffect. It appears that the names of these streams are hardcoded by Qt [1].

With Qt6, some changes happened in this area. Maybe upgrading to Qt6 would fix this in the future (allow grouping and/or renaming of Pulse streams).

[1] https://github.com/qt/qtmultimedia/blob/b4d58d8921d6d1c937b5e708e257e2a07a0c5dc4/src/multimedia/audio/qsoundeffect_pulse_p.cpp#L740-L741