swift-project / pilotclient

Cross-platform cross-simulator pilot client for virtual air traffic networks
https://swift-project.org
GNU General Public License v3.0
94 stars 27 forks source link

FSX selector grayed out in 64-bit build configuration wizard (required for MSFS) #178

Open ajungren opened 1 year ago

ajungren commented 1 year ago

On the swift download wiki page MSFS is incorrectly listed as compatible with both the 32-bit and 64-bit builds but only the 32-bit build is supported.

ltoenning commented 1 year ago

It should work with 32bit and 64bit. Only older 64bit versions of swift do not support MSFS.

Can you make sure, that the MSFS plugin is activated as described here: https://docs.swift-project.org/doku.php?id=msfs_configuration#msfs_activation.

ajungren commented 1 year ago

I selected MSFS during the setup...

swift1

...but the FSX checkbox is disabled in the configuration wizard.

swift2

ltoenning commented 1 year ago

Okay, that is indeed not correct. Thanks for reporting. But for now you should be able to set the paths later within the mapping tool (swiftdata). There you should be able to select FSX.

@oktal3700 The check is done here https://github.com/swift-project/pilotclient/blob/2ed20070486afdc8018222731ad08da4c10fef97/src/blackgui/components/configsimulatorcomponent.cpp#L75 Should we remove this check entirely for now to avoid confusion until the full MSFS integration is finished? The check if the version is compiled with a simulator support is not checked in other places either and does not depend on the installed plugins.

oktal3700 commented 1 year ago

@ltoenning I don't know it well enough to answer. If it looks good to you then go ahead.

ajungren commented 1 year ago

Thanks for getting on this so quickly, I figured I’d finally give VATSIM a shot while I’m trapped in my house.

I’m obviously super unfamiliar with the code base, but I created a PR that, at least for me, makes it work as expected if I understood correctly though like I said in the PR I need to test it more tomorrow and make sure it doesn’t break anything else.