search

swift-project / pilotclient

Cross-platform cross-simulator pilot client for virtual air traffic networks
https://swift-project.org
GNU General Public License v3.0
89 stars 26 forks source link

Move AFV URL to bootstrap.json #257

Closed ltoenning closed 4 months ago

ltoenning commented 5 months ago

Currently, the AFV voice server and map URLs are hardcoded at multiple places:

https://github.com/swift-project/pilotclient/blob/7e6f3f0f0d8bda6ec082f0947a6cf69dae4fc7c3/src/blackmisc/audio/voicesetup.h#L72-L73

https://github.com/swift-project/pilotclient/blob/7e6f3f0f0d8bda6ec082f0947a6cf69dae4fc7c3/src/blackcore/afv/model/afvmapreader.cpp#L33

Sample application: https://github.com/swift-project/pilotclient/blob/7e6f3f0f0d8bda6ec082f0947a6cf69dae4fc7c3/samples/afvclient/main.cpp#L40

For standardization it would be better to store the URLs in the bootstrap.json. This makes it easier to change the URLs when required.

aswinbabu352000 commented 5 months ago

I would like to work on this. Can you assign it to me?

ltoenning commented 5 months ago

Sure. If you have any questions about the issue or the source code, feel free to ask.

aswinbabu352000 commented 5 months ago

I tried to wrap my head around it but im unable to do it. I am unassigning myself.