swift-project / pilotclient

Cross-platform cross-simulator pilot client for virtual air traffic networks
https://swift-project.org
GNU General Public License v3.0
94 stars 28 forks source link

Remove CNetworkWatchdog #271

Closed ltoenning closed 7 months ago

ltoenning commented 8 months ago

The watchdog was used in a few places as a shortcut to skip reading data. Further, it was used in some places in the UI to display connectivity. But it also introduced quite some complexity. In some cases it can be fragile: network accessibilty cannot be looked up on all platforms/hardware constellations. The connectivity could change between the last watchdog call and the real call. Hence all readers must still handle the case where the connection fails.

To simplify swift and further reduce the dependency onto the project infrastructure (pings etc.), this PR removes the watchdog. This also removes the QNetworkConfigurationManager, which is deprecated and not available with Qt6.