swift-server-community / APNSwift

📱HTTP/2 Apple Push Notification Service built with swift - send push notifications to iOS, iPadOS, tvOS, macOS, watchOS, visionOS, and Safari!
Apache License 2.0
693 stars 105 forks source link

Breakout APNSwift into packages #170

Closed kylebrowning closed 1 year ago

kylebrowning commented 1 year ago

This is the first PR among probably many to break out APNS into APNSCore, APNSAHC, APNSUrlSession, and APNS(a hyper optimized h2 client)

vojtarylko commented 1 year ago

@kylebrowning Why APNSError.reason became private? The reason is vital for processing APNs' responses – for example sender may want to perform cleanup upon receiving Unregistered reason.

kylebrowning commented 1 year ago

@vojtarylko Im trying to remind myself why we did, but I can't think of it atm, do you wanna open a PR?

vojtarylko commented 1 year ago

@kylebrowning Thanks for the reply. I'll open PR.