search

swift-server-community / APNSwift

📱HTTP/2 Apple Push Notification Service built with swift - send push notifications to iOS, iPadOS, tvOS, macOS, watchOS, visionOS, and Safari!
Apache License 2.0
693 stars 105 forks source link

Keep failure reason PUBLIC #176

Closed ihamadfuad closed 1 year ago

ihamadfuad commented 1 year ago

/// The error code indicating the reason for the failure. public let reason: ErrorReason?

This property found public in main branch however in 5x.x is private!

I use this property to remove unregistered deviceTokens or other reason might occur to offload many failed push requests which all of us may already know how much time will save us to execute queues

Please keep it public in all branches

kylebrowning commented 1 year ago

Resolved in 5.0.0-beta.5

ihamadfuad commented 1 year ago

Thank you very much indeed, Kyle.