Make APNSClient Sendable if coders are Sendable

swift-server-community / APNSwift

📱HTTP/2 Apple Push Notification Service built with swift - send push notifications to iOS, iPadOS, tvOS, macOS, watchOS, visionOS, and Safari!

Apache License 2.0

693 stars 105 forks source link

Make APNSClient Sendable if coders are Sendable #195

Closed ffried closed 6 months ago

ffried commented 8 months ago

JSONEncoder and JSONDecoder also conform to Sendable, making the most commonly used APNSClient then Sendable as well.

kylebrowning commented 7 months ago

@FranzBusch sure, running checks

ffried commented 7 months ago

ThreadSanitizer: unexpected memory mapping

Hmm, is this TSan failure related to the new conformance? Seems unlikely to me...

0xTim commented 7 months ago

ThreadSanitizer: unexpected memory mapping

Hmm, is this TSan failure related to the new conformance? Seems unlikely to me...

GitHub have screwed up their runners on Linux so any LLVM ASAN/TSAN checks are failing. They have a fix that's due to deploy this week (I believe Friday) but as a workaround if you want it you can check out the issue which contains details and the workaround https://github.com/actions/runner-images/issues/9491#issuecomment-1999992492