search

swift-server / RediStack

Non-blocking, event-driven Swift client for Redis.
http://swiftpackageindex.com/swift-server/RediStack/documentation
Apache License 2.0
142 stars 21 forks source link

Add async variants of all commands #109

Closed joshuawright11 closed 2 months ago

joshuawright11 commented 3 months ago

Passthrough functions for all commands that calls the ELF variant with .get().

0xTim commented 3 months ago

@swift-server-bot please test

0xTim commented 3 months ago

@swift-server-bot add to allowlist

joshuawright11 commented 3 months ago

@0xTim thanks! I'm seeing errors in CI seemingly unrelated to this PR -

  1. error: redundant conformance of 'Gauge' to protocol 'Sendable' in Swift 5.7 🤔
  2. some Swift 6 errors on nightly

Any ideas what those might be? Can we drop 5.7 support?

0xTim commented 2 months ago

@joshuawright11 yeah I think we can drop 5.7 since NIO doesn't support it any more.

Nightly errors can potentially be ignored as well

joshuawright11 commented 2 months ago

@0xTim this is embarrassing but I'm not super familiar with Jenkins - it seems like configs aren't actually in this repo and someone with access to https://ci.swiftserver.group/ would need to disable the 5.6?

It's also throwing the same error as nightly on the api breakage pipeline - not sure what the solution is there.

joshuawright11 commented 2 months ago

@fabianfett got it - thanks for the reply, my bad for jumping on this PR instead of waiting for a response to my issue!

Glad to hear this repo is still maintained and I look forward to a fully async await version someday 😊