search

swift-server / async-http-client

HTTP client library built on SwiftNIO
https://swiftpackageindex.com/swift-server/async-http-client/main/documentation/asynchttpclient
Apache License 2.0
907 stars 116 forks source link

Licence is invalid #523

Closed 0xTim closed 2 years ago

0xTim commented 2 years ago

The Apache licence added to the project does not contain a copyright year or name of the copyright holder - https://github.com/swift-server/async-http-client/blob/main/LICENSE.txt#L190

This should probably be fixed...

fabianfett commented 2 years ago

cc @tomerd

Lukasa commented 2 years ago

We don't need @tomerd's help here, we can just update that file. Incidentally I don't believe that it renders the license invalid in any way, it's just a bit less convenient to copy into forks.

0xTim commented 2 years ago

Who's the code owner here? Swift, Apple or the SSWG? I'm only asking as we need to add a licence for the VSCode extension which is how I stumbled upon this

Lukasa commented 2 years ago

Copyright (c) 2019-2021 Apple Inc. and the AsyncHTTPClient project authors

weissi commented 2 years ago

@0xTim I think the LICENSE.txt file is actually supposed to have the placeholders.

The quoted line is after the END OF TERMS AND CONDITIONS in a section called APPENDIX: How to apply the Apache License to your work. which I believe is just there to tell you what you need to do in every file.

And from what I can tell, each file in AHC has the correct information (ie. the placeholders replaced with the real info).

0xTim commented 2 years ago

Hmm maybe you're right, in which case ignore me then!

ktoso commented 2 years ago

I think same as @weissi -- this is just the section of the license that says "this is how you apply it" -- the actual copyright headers in the actual files have the right info.

We can confirm with some actual legal authority; but another point of reference is Akka and Netty, both of which do the same thing: https://github.com/akka/akka/blob/main/LICENSE https://github.com/netty/netty/blob/4.1/LICENSE.txt - the file is just the template with placeholders.

I believe this/these issue(s) should be closed with no action taken.