Closed wsargent closed 3 years ago
Fantastic to hear from you Will, thanks! Going through the comments now 👍
Thanks a lot for the notes :-)
Overall, I think the biggest thing is making it clear that this is library specific advice, and discussing the use cases, i.e. are you going to be using this on iPhones, in a k8s cluster, in an internationalized environment etc.
To clarify, these guides are for server side systems, so pretty much always clusters or containers. The iOS ecosystem is a slightly different world and these Logging APIs are not used there for a number of reasons (most notably though that on those we have os_log which is the recommended way to log).
I'll apply some other feedback in the PR I have going here https://github.com/swift-server/guides/pull/41 thanks a lot
Konrad asked for some feedback of log-levels and so this is a trivial PR with a bunch of comments attached.
Overall, I think the biggest thing is making it clear that this is library specific advice, and discussing the use cases, i.e. are you going to be using this on iPhones, in a k8s cluster, in an internationalized environment etc. Everything else is just me scribbling in the margins. :-)