search

swift-server / swift-aws-lambda-runtime

Swift implementation of AWS Lambda Runtime
Apache License 2.0
1.13k stars 102 forks source link

Refactoring #145

Closed Roshankumar350 closed 4 years ago

Roshankumar350 commented 4 years ago

Improved design and structure.

Motivation:

Request and Response are different concern which need to be addressed separately

Modifications:

Refactored Request and Response

Result:

It will help to reduce complexity and maintain good code structure

swift-server-bot commented 4 years ago

Can one of the admins verify this patch?

swift-server-bot commented 4 years ago

Can one of the admins verify this patch?

swift-server-bot commented 4 years ago

Can one of the admins verify this patch?

swift-server-bot commented 4 years ago

Can one of the admins verify this patch?

ktoso commented 4 years ago

Hi @Roshanboy4u, thanks for the PR.

I'm not really convienced by the added value from the moving of the type here to be honest. Not sure if we'll want to merge this unless there's some other reasons and gains that I'm missing.

Roshankumar350 commented 4 years ago

Hi @ktoso Correct me if I'm wrong. I tried to address separation of concerns. So in near future when it will grow, it can be addressed with ease.

ktoso commented 4 years ago

I know what you mean but I'm not sure we want to accept this PR. Only shuffling code around is very prone to one or the other author's opinion and thus could result in back and forth PRs etc.

Thanks for the effort but let's close this one. Thanks