search

swift-server / swift-aws-lambda-runtime

Swift implementation of AWS Lambda Runtime
Apache License 2.0
1.13k stars 102 forks source link

Methods which never return (like run) should be marked as `-> Never` #151

Open helje5 opened 4 years ago

helje5 commented 4 years ago

As per PR #150, which needs to be fixed in more places.

Note that this is API semver major, so for 2.x.

helje5 commented 4 years ago

Of course you should be very sure whether you want the Never behaviour, but if you do - as documented -, it should return Never.

Why might you not want Never? I don't know, maybe because some Lambda's would want to switch the bootstrap for some crazy reason?

tomerd commented 4 years ago

lets do this with other breaking API changes for 1.0