search

swift-server / swift-aws-lambda-runtime

Swift implementation of AWS Lambda Runtime
Apache License 2.0
1.13k stars 102 forks source link

remove requirment on macOS 10.13 #156

Closed tomerd closed 4 years ago

tomerd commented 4 years ago

motivation: simplify downstream libraries

changes: use custom ISO8601 decoders on macOS < 10.13

tomerd commented 4 years ago

closes #152

tomerd commented 4 years ago

@helje5

tomerd commented 4 years ago

note strptime is not available via Glibc so this is a bit uglier with #if os blocks

tomerd commented 4 years ago

that sounds okay to me too. @helje5 wdyt?

helje5 commented 4 years ago

Either is fine for me. There are some Mac users which tend to stick to older versions, but they are probably not Swift target audience in the first place ;-)

helje5 commented 4 years ago

The really interesting question here is why spm decided to stick to 10.10 still, that feels a little weird, but the same reasoning should be applied i guess

tomerd commented 4 years ago

@fabianfett what is your concern about taking this as-is? code bloat/complexity?

fabianfett commented 4 years ago

@fabianfett what is your concern about taking this as-is? code bloat/complexity?

@tomerd I came to the conclusion, when I thought about, how we could test this... Date conversions should be tested by a unit test imho. When thinking about it, I wasn’t sure if there is actually a machine that could fulfill the requirements to run this branch. If there is no machine that the code could be ever run on, we shouldn’t add it because it increases complexity.

tomerd commented 4 years ago

@fabianfett addressed