Closed mufumade closed 3 years ago
Can one of the admins verify this patch?
Can one of the admins verify this patch?
Can one of the admins verify this patch?
Can one of the admins verify this patch?
Can one of the admins verify this patch?
Can one of the admins verify this patch?
@fabianfett Thanks for the feedback!
@swift-server-bot test this please
@mufumade Would you mind running swiftformat .
once in the project folder, to please the soundness check?
So this was a bit strange. At first swiftformat changed like 30 files although I only changed 2. On the second attempt swiftformat changed only the comment you provided with your suggestions. I hope it's all fine now.
@mufumade oh. sorry. it looks to me like our swiftformat
is a little out of date. I'm updating it right now and will post another pr. Once that swiftformat pr has landed, we update this pr and run swiftformat
again, which then should only affect your changed files. Sorry for the hassle and confusion.
@mufumade Would you mind resolving the merge conflicts and running swiftformat again? After that we should be ready to merge.
@swift-server-bot test this please
@fabianfett have a look at the newest commit.
@swift-server-bot test this please
@mufumade 👋 Ping: Are you still interested in getting this merged? I would love to see this land...
Oh. Sorry for the delay. I'll get started right away.
@fabianfett So i merged the current main into my branch, ran swiftformat again to check but I am not quite sure what you mean by re-adding the dropped internal acls?
@swift-server-bot test this please
@swift-server-bot test this please
Motivation:
194
Modifications:
Changed the S3.Event object size field to an optional due to the missing field on a s3:ObjectRemoved:* event Added one additional test to check propper json decoding
Result:
s3 event json will now decode successfully even if aws does not populate the
size
field.