Closed tomerd closed 3 years ago
cc @bmoffatt @kneekey23
Looks good to me. However we should have an "integration" test target in AWSLambdaEvents that ensures that the examples in the runtime still compile after a change in events.
@fabianfett you mean in the new "events" repo, so that changes there dont break the runtime? could they?
@fabianfett you mean in the new "events" repo, so that changes there dont break the runtime? could they?
The changes in there can't break the runtime, but the samples in the runtime repository, which would block CI.
The changes in there can't break the runtime, but the samples in the runtime repository, which would block CI.
it may ben easier (from a CI point of view) to add an example we can CI there as well. WDYT?
@tomerd Awesome! Now we should remove the APIGateway
example from the code here. All other examples don't depend on AWSLambdaEvents. Maybe we should add to the soundness script that we never import AWSLambdaEvents
except in markdown files :)
tomerd Awesome! Now we should remove the APIGateway example from the code here. All other examples don't depend on AWSLambdaEvents. Maybe we should add to the soundness script that we never import AWSLambdaEvents except in markdown files :)
done
Failing nightly-main CI because of known issue in SwiftNIO: https://github.com/apple/swift-nio/pull/1943 Not a blocker! Merging!
motivation: the runtime library has a stabel API while the events are still moving target, so in order to provide a 1.0 stable version we should separate them out
changes: