search

swift-server / swift-aws-lambda-runtime

Swift implementation of AWS Lambda Runtime
Apache License 2.0
1.13k stars 102 forks source link

split events into spearate package #216

Closed tomerd closed 3 years ago

tomerd commented 3 years ago

motivation: the runtime library has a stabel API while the events are still moving target, so in order to provide a 1.0 stable version we should separate them out

changes:

tomerd commented 3 years ago

cc @bmoffatt @kneekey23

tomerd commented 3 years ago

Looks good to me. However we should have an "integration" test target in AWSLambdaEvents that ensures that the examples in the runtime still compile after a change in events.

@fabianfett you mean in the new "events" repo, so that changes there dont break the runtime? could they?

fabianfett commented 3 years ago

@fabianfett you mean in the new "events" repo, so that changes there dont break the runtime? could they?

The changes in there can't break the runtime, but the samples in the runtime repository, which would block CI.

tomerd commented 3 years ago

The changes in there can't break the runtime, but the samples in the runtime repository, which would block CI.

it may ben easier (from a CI point of view) to add an example we can CI there as well. WDYT?

tomerd commented 3 years ago

@fabianfett https://github.com/swift-server/swift-aws-lambda-events/pull/1

fabianfett commented 3 years ago

@tomerd Awesome! Now we should remove the APIGateway example from the code here. All other examples don't depend on AWSLambdaEvents. Maybe we should add to the soundness script that we never import AWSLambdaEvents except in markdown files :)

tomerd commented 3 years ago

tomerd Awesome! Now we should remove the APIGateway example from the code here. All other examples don't depend on AWSLambdaEvents. Maybe we should add to the soundness script that we never import AWSLambdaEvents except in markdown files :)

done

fabianfett commented 3 years ago

Failing nightly-main CI because of known issue in SwiftNIO: https://github.com/apple/swift-nio/pull/1943 Not a blocker! Merging!