Clean up dependency graph and imports

swift-server / swift-aws-lambda-runtime

Swift implementation of AWS Lambda Runtime

Apache License 2.0

1.13k stars 102 forks source link

Clean up dependency graph and imports #218

Closed Lukasa closed 3 years ago

Lukasa commented 3 years ago

Motivation:

AWSLambdaRuntimeCore and MockServer both have dependencies on the NIO module, but they don't express this in their Package.swift: they implicitly rely on these dependencies being met by the NIOHTTP1 import. This was always brittle: it could lead to timing issues in the build that could lead to it failing.

Modifications:

Correctly express the dependency on NIO in Package.swift
Correctly import _NIOConcurrency in files where it's used

Result:

Better and more accurate builds.

fabianfett commented 3 years ago

Should we cherry pick this into a patch release? @tomerd @Lukasa

tomerd commented 3 years ago

Should we cherry pick this into a patch release? @tomerd @Lukasa