Adopt concurrency adoption guidelines - Githubissues

swift-server / swift-aws-lambda-runtime

Swift implementation of AWS Lambda Runtime

Apache License 2.0

1.13k stars 102 forks source link

Adopt concurrency adoption guidelines #230

Closed stevapple closed 2 years ago

stevapple commented 2 years ago

Adopt Swift Concurrency adoption guidelines for Swift Server Libraries (swift-server/guides#70).

Motivation:

Adopt Swift Concurrency adoption guidelines (for the correct way to import _Concurrency).

Modifications:

Use #if compiler(>=5.5) && canImport(_Concurrency) to judge if Concurrency is available;
Some cleaning.

swift-server-bot commented 2 years ago

Can one of the admins verify this patch?

swift-server-bot commented 2 years ago

Can one of the admins verify this patch?

swift-server-bot commented 2 years ago

Can one of the admins verify this patch?

swift-server-bot commented 2 years ago

Can one of the admins verify this patch?

swift-server-bot commented 2 years ago

Can one of the admins verify this patch?

swift-server-bot commented 2 years ago

Can one of the admins verify this patch?

swift-server-bot commented 2 years ago

Can one of the admins verify this patch?

stevapple commented 2 years ago

cc @tomerd @fabianfett

fabianfett commented 2 years ago

@swift-server-bot test this please

fabianfett commented 2 years ago

@stevapple Let's do the sendable checks in another pr please! We don't mind them for merging right now.

fabianfett commented 2 years ago

@swift-server-bot test this please (@tomerd @yim-lee could I get bot rights for this repo and lambda-events as well please?)

yim-lee commented 2 years ago

could I get bot rights for this repo and lambda-events as well please?

@fabianfett I believe you have them already. Are you experiencing issues?

fabianfett commented 2 years ago

Nightly failed because of Sendable checking.