search

swift-server / swift-aws-lambda-runtime

Swift implementation of AWS Lambda Runtime
Apache License 2.0
1.13k stars 102 forks source link

Modernize app example #231

Closed stevapple closed 2 years ago

stevapple commented 2 years ago

Update LocalDebugging example to reflect the latest SwiftUI practice.

Motivation:

Since we already required Swift 5.5 with Concurrency (Xcode 13), it's natural to update the app part to reflect latest SwiftUI changes, which makes the code neater and more expressive.

Modifications:

Result:

A better demo app.

swift-server-bot commented 2 years ago

Can one of the admins verify this patch?

swift-server-bot commented 2 years ago

Can one of the admins verify this patch?

swift-server-bot commented 2 years ago

Can one of the admins verify this patch?

swift-server-bot commented 2 years ago

Can one of the admins verify this patch?

swift-server-bot commented 2 years ago

Can one of the admins verify this patch?

swift-server-bot commented 2 years ago

Can one of the admins verify this patch?

swift-server-bot commented 2 years ago

Can one of the admins verify this patch?

tomerd commented 2 years ago

thank @stevapple !

lets get #228 in first

tomerd commented 2 years ago

@swift-server-bot test this please

stevapple commented 2 years ago

I've rebased the branch against #228, so there should be no pain to merge.

tomerd commented 2 years ago

@swift-server-bot test this please

tomerd commented 2 years ago

@swift-server-bot test this please

fabianfett commented 2 years ago

@tomerd ping

tomerd commented 2 years ago

@swift-server-bot test this please

stevapple commented 2 years ago

Xcode 13.2 and Swift Playgrounds 4 supports a new type of package-based app project (.swiftpm), and a preview of it can be seen here.

I’m wondering if such change is too aggressive as most of us still use .xcodeproj in production. @fabianfett @tomerd

stevapple commented 2 years ago

ping @tomerd @fabianfett